Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Text from Lark #13

Closed
phrohdoh opened this issue Jul 17, 2019 · 0 comments
Closed

Implement Text from Lark #13

phrohdoh opened this issue Jul 17, 2019 · 0 comments
Assignees

Comments

@phrohdoh
Copy link
Owner

The Lark project, which heavily influences the design of oraide, has a struct named Text that is essentially a slice of a String.

Lark uses this type to avoid expensive clones of Strings in and out of the salsa database which we currently do a lot of.

Implementing and using Text will theoretically improve performance of oraide but we have no numbers to support this claim currently.


I'm not sure yet in which component to put this Text type (or if a new component should be created).

@phrohdoh phrohdoh self-assigned this Jul 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant