Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to suppress all online-fallbacks and fall gracefully instead #32

Closed
phseiff opened this issue Apr 11, 2021 · 0 comments
Closed
Labels
enhancement New feature or request
Milestone

Comments

@phseiff
Copy link
Owner

phseiff commented Apr 11, 2021

Using an online formula converter (and potentially an online HTML-to-PDF converter in the future; see #31) as fallbacks if the required dependencies are not installed is one of gh-md-to-html's strengths, but can be tricky if one works with sensible files one doesn't want to upload on some internet service, especially since incorrectly setting up gh-md-to-html's dependencies (or, even worse, gh-md-to-html wrongly detecting these dependencies) could potentially lead to this happening on accident.

It might therefore be good a good idea to add an option --no-online-fallbacks to gh-md-to-html that turns off online fallbacks, causing gh-md-to-html to fail gracefully if a dependency is missing instead (whether this would imply and/or require -o OFFLINE or -o OFFLINE+ by default or just not care about the core converter at all is up for debate, though).

@phseiff phseiff added the enhancement New feature or request label Apr 11, 2021
@phseiff phseiff changed the title Add an option to suppress all online-fallbacks and fall gracefulyl instead Add an option to suppress all online-fallbacks and fall gracefully instead Apr 12, 2021
@phseiff phseiff added this to the Bug Cleanup milestone Jun 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant