Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIFO Support #272

Closed
richseviora opened this issue Nov 24, 2016 · 1 comment
Closed

FIFO Support #272

richseviora opened this issue Nov 24, 2016 · 1 comment

Comments

@richseviora
Copy link
Contributor

I'm using Shoryuken with a FIFO queue, and the AWS SDK is generating the following error when attempting to queue a job.
Aws::SQS::Errors::MissingParameter (The request must contain the parameter MessageGroupId.)

Research reveals that this is a required message attribute when working with FIFO queue. As per MessageGroupID section in this link.

I'll send a quick and dirty PR to generate a random one.
@richseviora
Copy link
Contributor Author

Opened PR #273.

@richseviora richseviora mentioned this issue Nov 25, 2016
Closed
phstc pushed a commit that referenced this issue Dec 3, 2016
Continuation of #273; Fixes #272; Apply some Shoryuken code style; Minor
1712350 
refactor
@phstc phstc mentioned this issue Dec 3, 2016
Merged
phstc pushed a commit that referenced this issue Dec 3, 2016
Continuation of #273; Fixes #272; Apply some Shoryuken code style; Minor
900c76a 
refactor
phstc pushed a commit that referenced this issue Dec 3, 2016
Continuation of #273; Fixes #272; Apply some Shoryuken code style; Minor
c46b8c5 
refactor
@phstc phstc closed this as completed in #276 Dec 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@richseviora