Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIFO & Exactly Once Processing #519

Closed
CGDS opened this issue Sep 19, 2018 · 4 comments
Closed

FIFO & Exactly Once Processing #519

CGDS opened this issue Sep 19, 2018 · 4 comments

Comments

@CGDS
Copy link

CGDS commented Sep 19, 2018

In the best practices section of the wiki and in #257, it talks about the importance of writing idempotent jobs as a consequence of SQS queues only guaranteeing at least once delivery. Since shoryuken also supports the newer FIFO queues now though, which do support exactly once processing, it seems like the documentation could use a little brushing up to mention the other option. If I got that right, that is. Mind if I open a PR?

@phstc
Copy link
Collaborator

phstc commented Sep 19, 2018

Mind if I open a PR?

@CGDS please 🙏 Actually for wiki pages, you don't need to PR, you can just update them!

Even with FIFO queues, it is still important to write idempotent workers, for example: in case a worker fails and you need to retry a partially executed message, if the visibility timeout expires etc. Besides that, FIFO only prevents dups sent within a 5 minutes interval as long as you use a valid "Message Deduplication ID".

@CGDS
Copy link
Author

CGDS commented Sep 19, 2018

Good point(s)
Made an edit, please feel free to revert or modify as you please

@phstc
Copy link
Collaborator

phstc commented Oct 1, 2018

Hi @CGDS

Which wiki did you change? I would love to have a 👀

I couldn't find updates here.

@phstc
Copy link
Collaborator

phstc commented Oct 1, 2018

NVM just found it https://github.com/phstc/shoryuken/wiki/Best-Practices

Thanks ❤️

In the best practices section of the wiki

I missed that part.

@phstc phstc closed this as completed Oct 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants