New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIFO & Exactly Once Processing #519
Comments
@CGDS please 🙏 Actually for wiki pages, you don't need to PR, you can just update them! Even with FIFO queues, it is still important to write idempotent workers, for example: in case a worker fails and you need to retry a partially executed message, if the visibility timeout expires etc. Besides that, FIFO only prevents dups sent within a 5 minutes interval as long as you use a valid "Message Deduplication ID". |
Good point(s) |
NVM just found it https://github.com/phstc/shoryuken/wiki/Best-Practices Thanks ❤️
I missed that part. |
In the best practices section of the wiki and in #257, it talks about the importance of writing idempotent jobs as a consequence of SQS queues only guaranteeing at least once delivery. Since shoryuken also supports the newer FIFO queues now though, which do support exactly once processing, it seems like the documentation could use a little brushing up to mention the other option. If I got that right, that is. Mind if I open a PR?
The text was updated successfully, but these errors were encountered: