Fix initialize logger #191
Conversation
| end | ||
|
|
||
| subject.process(queue, sqs_msg) rescue nil | ||
| end | ||
|
|
||
| it 're raises the error' do | ||
| expect{ subject.process(queue, sqs_msg) }.to raise_error(JSON::ParserError, "757: unexpected token at 'invalid json'") | ||
| expect{ subject.process(queue, sqs_msg) }.to raise_error(JSON::ParserError, "784: unexpected token at 'invalid json'") |
There was a problem hiding this comment.
Line is too long. [126/120]
Space missing to the left of {.
phstc
force-pushed
the
crowdworks-fix-initialize-logger
branch
from
26f8fac
to
01f3d6c
Compare
| @@ -15,12 +15,12 @@ def initialize(options) | |||
| end | |||
|
|
|||
| def load | |||
| Shoryuken.options.merge!(config_file_options) | |||
| Shoryuken.options.merge!(options) | |||
There was a problem hiding this comment.
@h3poteto in continuation of #181 (comment). This will logger out in the stdout, as the log wasn't initialized yet. But thinking more on it, I believe it should show an error and exit if the config file supplied is invalid. WDYT?
There was a problem hiding this comment.
I believe it should show an error and exit if the config file supplied is invalid.
I think it is right behavior.
LGTM
There was a problem hiding this comment.
This breaks loading the queues from the config when starting with the command-line client.
Basically, the default https://github.com/phstc/shoryuken/blob/master/lib/shoryuken/cli.rb#L115 will cause options to always have a :queues key and clobber whatever is supplied in the config file.
phstc
force-pushed
the
crowdworks-fix-initialize-logger
branch
from
01f3d6c
to
14ce22b
Compare
…g file does not exist
…g_file isn't supplied, it's a continuation of the change in f8f27fc; Replace raise with fail
Experiment based on #181