Add deprecation warning in initialize_aws #269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
h3poteto
force-pushed
the
add_deprecation_initialize_aws
branch
from
b92ed40
to
872999f
Compare
|
Thanks @h3poteto. Added to master 🍻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I add deprecation warning in
EnvironmentLoader#initialize_aws.In other times, I added aws configuration in
Shoryuken.configure_server: #252Now, Shoryuken has two methods to configure aws.
The first way is the method described above which is use
Shoryuken.configure_serverin initializer.The second way is the earlier method which is use
shoryuken.yml.I think it is intricate that there are two methods to configure aws.
So, I will remove the earlier method which is use
shoryuken.yml.Before remove that, I add deprecation warning in
EnvironmentLoader#initialize_aws.