Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove AwsConfig #317

Merged
merged 5 commits into from Feb 17, 2017
Merged

Remove AwsConfig #317

merged 5 commits into from Feb 17, 2017

Conversation

phstc
Copy link
Collaborator

@phstc phstc commented Feb 17, 2017

Fix #293

@phstc phstc merged commit 477c5f5 into v3 Feb 17, 2017
@phstc phstc deleted the remove-aws-config branch February 17, 2017 13:18
@phstc phstc changed the title WIP remove AwsConfig Remove AwsConfig Mar 13, 2017
@phstc phstc mentioned this pull request Mar 13, 2017
Closed
@unijewski unijewski mentioned this pull request Apr 11, 2017
Closed
@greggroth
Copy link

FYI This removed Shoryuken::Client.sns which was a breaking change that wasn't clearly mentioned in the Changelog (aside from a comment about removing AWS configuration). Also, the wiki is now out of date.

@phstc
Copy link
Collaborator Author

phstc commented Jun 12, 2017

Hi @greggroth

Good call. I've just updated the wiki.

Regarding to the breaking change, I assumed it was implied by the major release. But you are right, it should have been more explicit in the CHANGELOG.md.

@greggroth
Copy link

Thanks for the quick updates!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@phstc @greggroth