implement TSTP handling #492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phstc
reviewed
Apr 16, 2018
| when 'TERM', 'INT' | ||
| logger.info { "Received #{sig}, will shutdown down" } | ||
| logger.info { "Received #{sig}, will shutdown" } |
|
@sideshowdave7 thanks! Added to master 🍻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements TSTP signal handler: Fixes #479
TSTP tells Shoryuken to "quiet" as it will be shutting down at some point in the near future. It will stop fetching new jobs but continue working on current jobs. Use TSTP + TERM to guarantee shutdown within a time period. Best practice is to send TSTP at the start of a deploy and TERM at the end of a deploy.
Note you still need to send TERM to actually exit the Shoryuken process.
Tests:
I tested against a shoryuken process with no active jobs and it behaved as expected.
I also tested sending some jobs to the shoryuken process and verified active ones were allowed to finish, and new jobs stopped being accepted.
I looked around and didn't see any spec tests for signals.