Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect macOS version detection #18

Closed
Phundrak opened this issue Dec 30, 2021 · 0 comments
Closed

Incorrect macOS version detection #18

Phundrak opened this issue Dec 30, 2021 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@Phundrak
Copy link
Owner

My macOS VM runs undern macOS Catalina, version 10.15. However, the
eshell-info-banner--get-macos-name macro matches version 10.1 first,
resulting in Mac OS X Puma being detected instead.
@Phundrak Phundrak added bug Something isn't working good first issue Good for newcomers labels Dec 30, 2021
Phundrak added a commit that referenced this issue Mar 26, 2022
@Phundrak
Fix macOS version detection
9c17e92 
Now use regexes to detect the macOS version returned by
`sw_vers -productVersion`

Also add new macOS version

Fixes #18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Phundrak