Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logical bug in VHRroutine #47

Closed
jo-ym opened this issue May 7, 2022 · 1 comment
Closed

Logical bug in VHRroutine #47

jo-ym opened this issue May 7, 2022 · 1 comment

Comments

@jo-ym
Copy link

jo-ym commented May 7, 2022

Hi, we want to cite this project so we research it.
But we found there may be a logical bug in the ./pyVHR/realtime/VHRroutine.py.
The block of if-statement, line 192.
The counting method will count one more frame to the sig_stride (fps)?
So the number of the windows will be not correct.
@giulianogrossi
Copy link
Collaborator

A new version of the framework, pyVHR 2.0, has been released. Please check if problems persist and report them for future bug fixes.

best
the pyVHR team

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@giulianogrossi @jo-ym