Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AsyncWriter should supports writev #12

Closed
phuslu opened this issue Aug 22, 2020 · 2 comments
Closed

AsyncWriter should supports writev #12

phuslu opened this issue Aug 22, 2020 · 2 comments

Comments

@phuslu
Copy link
Owner

phuslu commented Aug 22, 2020 •
edited

Two step,

  1. add writev support in FileWriter on linux.
  2. add writev in AsyncWriter base on step 1

A draft already pushed to branch writev https://github.com/phuslu/log/blob/writev/async_writev.go
@phuslu
Copy link
Owner Author

phuslu commented Aug 23, 2020 •
edited

merged. 1e28388

@phuslu phuslu closed this as completed Aug 23, 2020
@phuslu
Copy link
Owner Author

phuslu commented Aug 29, 2020

no obviously performance improvment, so reverted at 33e4cde

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@phuslu