Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manual entry not working? #21

Closed
drvinceknight opened this issue Nov 30, 2014 · 4 comments
Closed

Manual entry not working? #21

drvinceknight opened this issue Nov 30, 2014 · 4 comments

Comments

@drvinceknight
Copy link
Contributor

Hi I'm just getting started with BMC. I get an error when pointing it at an old pdf for which I can't seem to find the DOI so hoping to use manual:

~$ python BMC/bmc.py import ~/Desktop/yadin_1965.pdf
DOI / arXiv / ISBN / manual / skip? manual
The bibtex entry found for /Users/vince/Desktop/yadin_1965.pdf is:
Traceback (most recent call last):
  File "BMC/bmc.py", line 550, in <module>
    args.tag)
  File "BMC/bmc.py", line 188, in addFile
    bibtex = checkBibtex(src, bibtex_string)
  File "BMC/bmc.py", line 30, in checkBibtex
     bibtex = bibtex[list(bibtex.keys())[0]]
IndexError: list index out of range

Have I got the use case wrong for manual or is it not implemented yet?

Phyks added a commit that referenced this issue Nov 30, 2014
@Phyks
Copy link
Owner

Phyks commented Nov 30, 2014

Should be ok by now.

@Phyks Phyks closed this as completed Nov 30, 2014
@drvinceknight
Copy link
Contributor Author

Sorry no this is still not working for me.

BMC (master>)$ python bmc.py import ~/Desktop/yadin_1965.pdf
DOI / arXiv / ISBN / manual / skip? manual
The bibtex entry found for /Users/vince/Desktop/yadin_1965.pdf is:
Press Enter to go back to editor.
Press Enter to go back to editor.
Press Enter to go back to editor.

About to send you a pull request with my fix (almost similar to yours except I seem to be having problems reading from tmp files).

@Phyks
Copy link
Owner

Phyks commented Dec 2, 2014

Ok, you found a problem with tempfiles in Python3, compared to Python2. I was not aware of this…

I just tried with Python2, and everything works fine AFAIK. I'll have a look ASAP to solve it definitely.

@Phyks Phyks reopened this Dec 2, 2014
Phyks added a commit that referenced this issue Dec 3, 2014
@Phyks
Copy link
Owner

Phyks commented Dec 3, 2014

Ok, the problem was different I think. It was an update in the bibtexparser module which resulted in a failure to parse provided bibtex entries.

I tested it and it should all be ok by now. I tagged a new version for this fix. Please, let me know and reopen the issue if you still experience some issues.

@Phyks Phyks closed this as completed Dec 3, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants