Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add index caching to Faces and use it instead of SimulationMap::find_face_index #41

Open
kolayne opened this issue Nov 22, 2020 · 0 comments
Open

Add index caching to Faces and use it instead of SimulationMap::find_face_index #41

kolayne opened this issue Nov 22, 2020 · 0 comments
Labels
refactoring

Comments

@kolayne
Copy link
Member

kolayne commented Nov 22, 2020

I don't like the implementation of find_face_index. I believe it would be better to have a Face method, returning a cached value instead of this function
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactoring
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kolayne