Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SimulationMap constructor: set Face::node fields after all the MapNodes are created #7

Closed
kolayne opened this issue Aug 8, 2020 · 0 comments · Fixed by #9
Closed

SimulationMap constructor: set Face::node fields after all the MapNodes are created #7

kolayne opened this issue Aug 8, 2020 · 0 comments · Fixed by #9
Assignees
@tanya-kta
Labels
bug Something isn't working

Comments

@kolayne
Copy link
Member

kolayne commented Aug 8, 2020

Current SimulationMap's implementation requires moving MapNodes, but because the Face::node fields are set to pointers to MapNodes during the creation of the grid of nodes, moving them invalidates the pointers set at faces.

The solution is to set Face::node fields only after the whole grid is created, at the end of SimulationMap constructor
@kolayne kolayne added the bug Something isn't working label Aug 8, 2020
tanya-kta added a commit that referenced this issue Aug 9, 2020
@tanya-kta
Fixes #7
6e5f7b1
@tanya-kta tanya-kta mentioned this issue Aug 9, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tanya-kta tanya-kta

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move the Face::node fields setting after all MapNodes creation physarumAdv/minds_crawl
2 participants
@kolayne @tanya-kta