Incorrect bme680 calibration register address

[Tom-Newton]

This doesn't actually seem to cause any problems though I suspect if compiled in debug mode this would cause crashes due to trying to write to unallocated memory. I just spotted this when looking at the code.

The number of bme680 calibration constants:

Warp-firmware/src/boot/ksdk1.1.0/warp.h

Line 170 in 96e67b9

kWarpSizesBME680CalibrationValuesCount = 41,

is not consistent with the range of addresses it attempts to read from:

Warp-firmware/src/boot/ksdk1.1.0/warp.h

Lines 222 to 225 in 96e67b9

	kWarpSensorConfigurationRegisterBME680CalibrationRegion1Start = 0x89,
	kWarpSensorConfigurationRegisterBME680CalibrationRegion1End = 0xA2,
	kWarpSensorConfigurationRegisterBME680CalibrationRegion2Start = 0xE1,
	kWarpSensorConfigurationRegisterBME680CalibrationRegion2End = 0xF2,

These constants are used here:

Warp-firmware/src/boot/ksdk1.1.0/devBME680.c

Lines 172 to 186 in 96e67b9

	for ( reg = kWarpSensorConfigurationRegisterBME680CalibrationRegion1Start;
	reg < kWarpSensorConfigurationRegisterBME680CalibrationRegion1End;
	reg++)
	{
	status4 |= readSensorRegisterBME680(reg, 1 /* numberOfBytes */);
	deviceBME680CalibrationValues[index++] = deviceBME680State.i2cBuffer[0];
	}
	for ( reg = kWarpSensorConfigurationRegisterBME680CalibrationRegion2Start;
	reg < kWarpSensorConfigurationRegisterBME680CalibrationRegion2End;
	reg++)
	{
	status4 |= readSensorRegisterBME680(reg, 1 /* numberOfBytes */);
	deviceBME680CalibrationValues[index++] = deviceBME680State.i2cBuffer[0];
	}

and this declaration is relavent

Warp-firmware/src/boot/ksdk1.1.0/warp-kl03-ksdk1.1-boot.c

Line 145 in 96e67b9

volatile uint8_t deviceBME680CalibrationValues[kWarpSizesBME680CalibrationValuesCount];

These for loops read from 42 different memory locations and write the contents to an array of length 41.

I believe the fix is to set this:

Warp-firmware/src/boot/ksdk1.1.0/warp.h

Line 225 in 96e67b9

kWarpSensorConfigurationRegisterBME680CalibrationRegion2End = 0xF2,

to 0xf1.

Hopefully I haven't just completely misunderstood something here.

[JamesTimothyMeech]

Hello Tom, sorry about the delay in getting back to you on this.

Looks like you're correct and there is a mistake here

Would you like to go ahead and make a pull request for this so you get credit for the fix?

Or would you prefer that I go ahead and do it?

[Tom-Newton]

I'm happy to make a PR but I don't know any way that I could test it.

[JamesTimothyMeech]

Ah I see what you mean. I'll make the change and test it sometime soon. Providing it doesn't break anything we can then make the PR and merge it in.