Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CPM (Kassinopoulos & Mitsis 2020) #24

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Add CPM (Kassinopoulos & Mitsis 2020) #24

wants to merge 4 commits into from

Conversation

tsalo
Copy link
Member

@tsalo tsalo commented Jan 7, 2021

Closes #23.

This is currently just a draft with a direct, untested translation from MATLAB to Python.

Proposed Changes

  • Add functions related to calculating the cardiac pulsatility model (CPM) metric.

Change Type

  • bugfix (+0.0.1)
  • minor (+0.1.0)
  • major (+1.0.0)
  • refactoring (no version update)
  • test (no version update)
  • infrastructure (no version update)
  • documentation (no version update)
  • other

Checklist before review

  • I added everything I wanted to add to this PR.
  • [Code or tests only] I wrote/updated the necessary docstrings.
  • [Code or tests only] I ran and passed tests locally.
  • [Documentation only] I built the docs locally.
  • My contribution is harmonious with the rest of the code: I'm not introducing repetitions.
  • My code respects the adopted style, especially linting conventions.
  • The title of this PR is explanatory on its own, enough to be understood as part of a changelog.
  • I added or indicated the right labels.
  • I added information regarding the timeline of completion for this PR.
  • Please, comment on my PR while it's a draft and give me feedback on the development!

@tsalo
Copy link
Member Author

tsalo commented Jan 7, 2021

The code successfully runs on random arrays! I still need to make sure that my variable names and comments reflect the actual variables, hopefully with input from the original creator.

@tsalo tsalo changed the title Add cardiac pulsatility model Add CPM (Kassinopoulos & Mitsis 2020) Jan 8, 2021
@tsalo tsalo added the Minormod This PR generally closes an "Enhancement" issue. It increments the minor version (0.+1.0) label Jan 8, 2021
@rgbayrak
Copy link

rgbayrak commented Apr 18, 2024 •
edited
Loading

I have had issues translating code from MATLAB to python. I would check the output signals side-by-side before merging this. More specifically there is a discrepancy in signal filtering.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Minormod This PR generally closes an "Enhancement" issue. It increments the minor version (0.+1.0)
Projects
Physiopy
Status: Need help!
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Requested metric: cardiac pulsatility model
2 participants
@tsalo @rgbayrak