Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to use blacklist button #1536

Closed
3 tasks done
phil-ide opened this issue Jul 28, 2020 · 6 comments
Closed
3 tasks done

Unable to use blacklist button #1536

phil-ide opened this issue Jul 28, 2020 · 6 comments

Comments

@phil-ide
Copy link

In raising this issue, I confirm the following: {please fill the checkboxes, e.g: [X]}

How familiar are you with the the source code relevant to this issue?:

0


Expected behavior:

After upgrading from v5.0 to v5.1.1:
Pressing 'Blacklist' button in the Query Log should add a doman to the blacklist.

Actual behavior:
The popup message informing the domain has been added is displayed as usual. However, checking the blacklist shows it has not been added. From another machine, surfing to the supposedly blacklisted domain shows (in the log) that it has not been blacklisted and has been forwarded.

Steps to reproduce:
Press the blacklist button for a domain in the Query Log, then try to surf to the domain. Checkin the Blacklist for the entry.

Troubleshooting undertaken, and/or other relevant information:
I have performed the "echo 4711 > /var/run/pihole-FTL.port" and "pihole -c" now reports FTL running properly. The issue being reported occurs both before and after these steps.

@s-fairchild
Copy link

I'm having the same issue as well, domains in the blacklist also do not show up in the web GUI.

The pihole commands seem to still work and allow you to edit the blacklist.

-w, whitelist Whitelist domain(s)
-b, blacklist Blacklist domain(s)
--regex, regex Regex blacklist domains(s)
--white-regex Regex whitelist domains(s)
--wild, wildcard Wildcard blacklist domain(s)
--white-wild Wildcard whitelist domain(s)

@dschaper dschaper transferred this issue from pi-hole/pi-hole Jul 30, 2020
@jfb-pihole
Copy link
Sponsor Member

Have you cleared the browser cache and reloaded the Pi-hole web GUI?

@phil-ide
Copy link
Author

I have tried that, but that wouldn't actually make any difference to the pi-hole forwarding domains and giving them the green light after the blacklist button had been pressed on them from an earlier request. Neither would it make any difference to a force-reload (ctrl-F5) on the blacklist in the GUI, which should show the backlisted item. The fact is, pressing the blacklist button in the query log doesn't do anything except display a message saying the item has been blacklisted.

My workaround is to head straight to the blacklist and manually enter domains I want blacklisted, so it's not a mission critical failure, it's just erroneous behaviour.

@pralor-bot
Copy link

This issue has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/whitelist-button-doesnt-work-in-query-log-page/35695/24

@vossilius
Copy link

+1

@github-actions
Copy link
Contributor

This issue is stale because it has been open 30 days with no activity. Please comment or update this issue or it will be closed in 5 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants