Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getAllQueries falls over when gravity.list contains large number of domains #73

Closed
PromoFaux opened this issue Apr 15, 2016 · 10 comments
Closed

Comments

@PromoFaux
Copy link
Member

Continuation of #465 on the main pi-hole repo.

@PromoFaux PromoFaux added the Bug label Apr 15, 2016
@PromoFaux PromoFaux mentioned this issue Apr 15, 2016
@PromoFaux
Copy link
Member Author

@Windyo
@CDeeRON
@7h3ju57

I've only gone and done it.

Can one of you test this for me please?

cd /var/www/html/admin
sudo git fetch
sudo git checkout BugFix73

to revert, sudo git checkout master

@CDeeRON
Copy link

CDeeRON commented Apr 15, 2016

I had to git reset --hard since I was playing around with data.php

Fixes work for me

@PromoFaux
Copy link
Member Author

ah yes! Should have mentioned that.

But super, glad that works. We'll try and push it to release tonight, I think there are a couple of other minor bugs to sort out, too.

@CDeeRON
Copy link

CDeeRON commented Apr 15, 2016

I see below error in /var/log/lighttpd/error.log

2016-04-15 16:21:19: (mod_fastcgi.c.2695) FastCGI-stderr: PHP Notice: Undefined variable: status in /var/www/html/admin/data.php on line 138

if ( $status != ""){ array_push($allQueries['data'], array( $time->format('Y-m-d\TH:i:s'), $type, $domain, $client, $status, )); $status = ""; }

@PromoFaux
Copy link
Member Author

OK, should have that sorted... update and try again...

@CDeeRON
Copy link

CDeeRON commented Apr 15, 2016

Updated and tested with no errors, both the admin/api.php?getAllQueries and /admin/queries.php

@Windyo
Copy link

Windyo commented Apr 16, 2016

Was away from the computer, sorry. Confirmed working here too 👍

@PromoFaux
Copy link
Member Author

@CDeeRON @Windyo @7h3ju57 This is now released, so switch back to master branch on your local machines and update! Also another couple of bonus updates in there, too!

@Windyo
Copy link

Windyo commented Apr 16, 2016

Running update !

@CDeeRON
Copy link

CDeeRON commented Apr 16, 2016

Update looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants