Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Network overview page is not correctly sorting for IP #947

Closed
3 tasks done
Deses opened this issue May 28, 2019 · 1 comment
Closed
3 tasks done

Network overview page is not correctly sorting for IP #947

Deses opened this issue May 28, 2019 · 1 comment

Comments

@Deses
Copy link

Deses commented May 28, 2019

In raising this issue, I confirm the following: {please fill the checkboxes, e.g: [X]}

How familiar are you with the the source code relevant to this issue?:

1


Expected behaviour:

I expect to see the IPs in a consecutive fashion:
192.168.1.1
192.168.1.2
192.168.1.3
192.168.1.4
....
192.168.1.22
192.168.1.33
192.168.1.44

Actual behaviour:

The IPs are sorted but the 4th octet is being sorted on it own.

192.168.1.1
192.168.1.11
192.168.1.2
192.168.1.22
192.168.1.3
192.168.1.33
192.168.1.4
192.168.1.44

image

Steps to reproduce:

Just access the Network Overview and sort by IP.

Debug token provided by uploading pihole -d log:

I couldn't upload the log as I'm getting this error...
There was an error uploading your debug log.

@AzureMarker AzureMarker transferred this issue from pi-hole/pi-hole May 29, 2019
@Deses
Copy link
Author

Deses commented May 30, 2019

Thanks @Mcat12 for moving the issue to the correct repo and thanks @DL6ER for pointing me to the PR where this is being addressed.

Closing this issue then. :)

@Deses Deses closed this as completed May 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant