Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve domain pages #1184

Merged
merged 6 commits into from Mar 15, 2020
Merged

Improve domain pages #1184

merged 6 commits into from Mar 15, 2020

Conversation

DL6ER
Copy link
Member

@DL6ER DL6ER commented Mar 15, 2020

By submitting this pull request, I confirm the following:

  • I have read and understood the contributors guide, as well as this entire template.
  • I have made only one major change in my proposed changes.
  • I have commented my proposed changes within the code.
  • I have tested my proposed changes, and have included unit tests where possible.
  • I am willing to help maintain this change if there are issues with it later.
  • I give this submission freely and claim no ownership.
  • It is compatible with the EUPL 1.2 license
  • I have squashed any insignificant commits. (git rebase)

What does this PR aim to accomplish?:

Improve clarity of the black-/whitelist and domain management pages

How does this PR accomplish the above?:

As discussed on Discourse (see comment below).

OLD

Screenshot at 2020-03-15 20-00-59

NEW

Screenshot at 2020-03-15 20-01-20

What documentation changes (if any) are needed to support this PR?:

None

DL6ER and others added 6 commits March 5, 2020 20:31
Signed-off-by: DL6ER <dl6er@dl6er.de>
Signed-off-by: DL6ER <dl6er@dl6er.de>
Signed-off-by: DL6ER <dl6er@dl6er.de>
Signed-off-by: Th3M3 <the_me@outlook.de>
Signed-off-by: DL6ER <dl6er@dl6er.de>
@DL6ER DL6ER added this to the v5.0 milestone Mar 15, 2020
@DL6ER DL6ER requested a review from a team March 15, 2020 19:02
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/rename-wildcard-blacklist-whitelist-because-it-is-misleading-and-lead-to-regex-errors/28867/82

@dschaper dschaper merged commit bc9c656 into release/v5.0 Mar 15, 2020
@dschaper dschaper deleted the tweak/domain_regex_input branch March 15, 2020 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants