Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify query log filter to make it more user friendly #1602

Merged
merged 1 commit into from Oct 13, 2020

Conversation

PromoFaux
Copy link
Member

By submitting this pull request, I confirm the following:

  • I have read and understood the contributors guide, as well as this entire template.
  • I have made only one major change in my proposed changes.
  • I have commented my proposed changes within the code.
  • I have tested my proposed changes, and have included unit tests where possible.
  • I am willing to help maintain this change if there are issues with it later.
  • I give this submission freely and claim no ownership.
  • It is compatible with the EUPL 1.2 license
  • I have squashed any insignificant commits. (git rebase)

What does this PR aim to accomplish?:

  • Allows mobile users to be able to use the new filtering options as well as desktop users
  • Removes need to hold down a modifier key to add or remove to/from the filter. Simply click the field to toggle it on/off
  • Utilises the ctrl/meta modifier keys for desktop users to enable highlighting to copy cell text to the clipboard (mobile users can long-press the cell text to achieve the same thing)

How does this PR accomplish the above?:

What documentation changes (if any) are needed to support this PR?:

Possibly docs, I've not checked. This may need to be replicated to long term tables?

Don't require modifier keys to interact (now works on mobile)
Hold modifier key to enable selection for copying domain (long press on mobile)

Signed-off-by: Adam Warner <me@adamwarner.co.uk>
Copy link
Member

@DL6ER DL6ER left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should clearly mention this in the change log / release notes

@DL6ER DL6ER merged commit e06278d into devel Oct 13, 2020
@DL6ER DL6ER deleted the tweak/queryfilters_new branch October 13, 2020 15:00
@yubiuser
Copy link
Member

This may need to be replicated to long term tables?

Yes, but before the whole "new" filtering has to be implemented in the long-term tables: https://discourse.pi-hole.net/t/extend-query-table-filtering-from-v5-1-to-long-term-data-query-log/35634

@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/pi-hole-core-web-v5-2-and-ftl-v5-3-released/40909/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants