Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

standalone mode for iOS #203

Merged
merged 1 commit into from Nov 21, 2016
Merged

standalone mode for iOS #203

merged 1 commit into from Nov 21, 2016

Conversation

JdenHartog
Copy link
Contributor

Fixes #[none] .

Changes proposed in this pull request:

@pi-hole/dashboard

This will make the admin page look more like a native iOS application when started from Home Screen on iOS. It also won't create a tab in iOS Safari and will make spaceflight more convenient. See *Hiding Safari User Interface Components* on:

https://developer.apple.com/library/content/documentation/AppleApplications/Reference/SafariWebContent/ConfiguringWebApplications/ConfiguringWebApplications.html
@CLAassistant
Copy link

CLAassistant commented Nov 20, 2016

CLA assistant check
All committers have signed the CLA.

@DL6ER
Copy link
Member

DL6ER commented Nov 20, 2016

I like the idea, however, I cannot test it (because of not having an iOS device). Could you provide screenshots before/after?

@PromoFaux
Copy link
Member

Do you have an android device @DL6ER? I think this is essentially the same as using the "add to home screen" option on Chrome... I might be wrong.

@PromoFaux
Copy link
Member

PromoFaux commented Nov 20, 2016

OK, to revise my above comment...

Using "Add to homescreen" on Chrome without this will just open it as a new tab. With this modification, it opens as it's own "app". Nice little detail.

Approved

Approved with PullApprove

@DL6ER
Copy link
Member

DL6ER commented Nov 20, 2016

Just tested it, Chrome even shows a splash screen on startup. Very nice!
screenshot_20161120-204154

@AzureMarker
Copy link
Contributor

AzureMarker commented Nov 20, 2016

Approved.

Approved with PullApprove

@PromoFaux
Copy link
Member

@JdenHartog In order for us to merge this pull request, we need you to sign the contributor license agreement

Thanks!

@JdenHartog
Copy link
Contributor Author

You're welcome! Thank you guys for pi-hole!

I signed the contributor license agreement.

@PromoFaux PromoFaux merged commit 6230c88 into pi-hole:devel Nov 21, 2016
@JdenHartog JdenHartog deleted the patch-1 branch January 2, 2017 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants