Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update browserlist #2344

Merged
merged 1 commit into from Sep 11, 2022
Merged

Update browserlist #2344

merged 1 commit into from Sep 11, 2022

Conversation

yubiuser
Copy link
Member

@yubiuser yubiuser commented Sep 11, 2022

What does this PR aim to accomplish?:

Updates browserslist. Currently, the node report a warning

Browserslist: caniuse-lite is outdated. Please run:
npx browserslist@latest --update-db
Why you should do it regularly: https://github.com/browserslist/browserslist#browsers-data-updating

E.g. here: https://github.com/pi-hole/AdminLTE/runs/8282732201?check_suite_focus=true

This PR simply executed the suggest npx browserslist@latest --update-db and created a commit from the diff.


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)

  • I have read the above and my PR is ready for review. Check this box to confirm

@yubiuser yubiuser requested a review from a team September 11, 2022 19:02
@yubiuser yubiuser added the PR: Approval Required Open Pull Request, needs approval label Sep 11, 2022
@yubiuser
Copy link
Member Author

Test now don't throw a warning anymore: https://github.com/pi-hole/AdminLTE/runs/8294574728?check_suite_focus=true

Signed-off-by: Christian König <ckoenig@posteo.de>
@yubiuser yubiuser merged commit 23b0371 into devel Sep 11, 2022
@yubiuser yubiuser deleted the fix/browserlist branch September 11, 2022 19:26
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/pi-hole-ftl-v5-18-web-v5-15-and-core-v5-12-1-released/57894/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Approval Required Open Pull Request, needs approval
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants