Increase small-box footer contrast ratio #2432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contrast ratio is still low, but this should improve things. Generally, it's advised to aim for a contrast ratio of 4.5. Signed-off-by: XhmikosR <xhmikosr@gmail.com>
XhmikosR
commented
Nov 15, 2022
rdwebdesign
requested changes
Nov 15, 2022
|
Sorry, I don't have the time to make such changes right now. It was a
suggestion for the future. And it's unrelated to this PR, anyway, I just
happened to see it here :)
…On Tue, Nov 15, 2022, 19:45 RD WebDesign ***@***.***> wrote:
***@***.**** requested changes on this pull request.
------------------------------
In style/pi-hole.css
<#2432 (comment)>:
> @@ -447,7 +447,7 @@ td.lookatme {
}
.small-box > .small-box-footer {
- color: rgba(255, 255, 255, 0.5);
+ color: rgba(255, 255, 255, 0.75);
transition: all 0.5s;
If you think all should be replaced by individual properties, can you
please add this change?
—
Reply to this email directly, view it on GitHub
<#2432 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACVLNK562K5EUNI7KB3VKTWIPD3VANCNFSM6AAAAAASATPENQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
rdwebdesign
previously approved these changes
Nov 15, 2022
PromoFaux
approved these changes
Dec 11, 2022
|
This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there: https://discourse.pi-hole.net/t/pi-hole-ftl-v5-20-and-web-v5-18-released/59959/1 |
|
This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there: https://discourse.pi-hole.net/t/api-php-most-functions-do-not-work/60104/2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contrast ratio is still low, but this should improve things. Generally, it's advised to aim for a contrast ratio of 4.5.
Signed-off-by: XhmikosR xhmikosr@gmail.com
Thank you for your contribution to the Pi-hole Community!
Please read the comments below to help us consider your Pull Request.
We are all volunteers and completing the process outlined will help us review your commits quicker.
Please make sure you
What does this PR aim to accomplish?:
How does this PR accomplish the above?:
Link documentation PRs if any are needed to support this PR:
By submitting this pull request, I confirm the following:
git rebase)