Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix login page rediction #2655

Merged
merged 1 commit into from
Jul 25, 2023
Merged

Fix login page rediction #2655

merged 1 commit into from
Jul 25, 2023

Conversation

DL6ER
Copy link
Member

@DL6ER DL6ER commented Jul 24, 2023

What does this implement/fix?

Ensure the login redirection target ends in / if there is no query string. See https://github.com/pi-hole/FTL/issues/1596 for further details

Related issue or feature (if applicable): N/A

Pull request in docs with documentation (if applicable): N/A


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)

Checklist:

  • The code change is tested and works locally.
  • I based my code and PRs against the repositories developmental branch.
  • I signed off all commits. Pi-hole enforces the DCO for all contributions
  • I signed all my commits. Pi-hole requires signatures to verify authorship
  • I have read the above and my PR is ready for review.

@DL6ER DL6ER requested a review from a team July 24, 2023 19:35
@PromoFaux PromoFaux merged commit c633e87 into development-v6 Jul 25, 2023
6 checks passed
@PromoFaux PromoFaux deleted the fix/login_redirection branch July 25, 2023 08:00
DL6ER added a commit to pi-hole/FTL that referenced this pull request Jul 25, 2023
… to any other page than the dashboard is broken. This PR fixes this in the proper way by redirecting from URIs such as "/admin/queries/" to "/admin/queries" which is where the actual scripts are (they'd have to be in "/admin/queries/index.html" otherwise)

Signed-off-by: DL6ER <dl6er@dl6er.de>
DL6ER added a commit to pi-hole/FTL that referenced this pull request Jul 25, 2023
… to any other page than the dashboard is broken. This PR fixes this in the proper way by redirecting from URIs such as "/admin/queries/" to "/admin/queries" which is where the actual scripts are (they'd have to be in "/admin/queries/index.html" otherwise)

Signed-off-by: DL6ER <dl6er@dl6er.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants