Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

open links up in new tab #511

Merged
merged 3 commits into from May 24, 2017
Merged

open links up in new tab #511

merged 3 commits into from May 24, 2017

Conversation

Th3M3
Copy link
Contributor

@Th3M3 Th3M3 commented May 19, 2017

By submitting this pull request, I confirm the following (please check boxes, eg [X] - no spaces) Failure to fill the template will close your PR:

Please submit all pull requests against the development branch. Failure to do so will delay or deny your request

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.

How familiar are you with the codebase?:

1


Links in Dashboard shoud open up in a new tab. Solves partially #333.

This template was created based on the work of udemy-dl.

@AzureMarker
Copy link
Contributor

AzureMarker commented May 19, 2017

Approved

Approved with PullApprove

@DL6ER DL6ER merged commit bbe0ff4 into pi-hole:devel May 24, 2017
@Th3M3 Th3M3 deleted the links_in_new_tab branch May 24, 2017 16:22
@Th3M3
Copy link
Contributor Author

Th3M3 commented May 30, 2017

Today I found out that the links in the header's dropdown menu generate a new issue when open up their url in a new tab/window:

On clicking on the link their background toggles to gray.

I will look on it and work out a solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants