Fix sorting of queries with identical timestamps #938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: DL6ER <dl6er@dl6er.de>
Signed-off-by: DL6ER <dl6er@dl6er.de>
Signed-off-by: DL6ER <dl6er@dl6er.de>
Remove jQuery inputmask
Signed-off-by: Adam Warner <me@adamwarner.co.uk>
Set "orderable" to false on last column of network table
…ame second. Fixes #934 Signed-off-by: DL6ER <dl6er@dl6er.de>
Signed-off-by: DL6ER <dl6er@dl6er.de>
|
Opened as draft PR as the code changes need to be repeated for the long-term query table. |
AzureMarker
reviewed
May 5, 2019
…en the date string is shown. Signed-off-by: DL6ER <dl6er@dl6er.de>
Signed-off-by: DL6ER <dl6er@dl6er.de>
AzureMarker
reviewed
May 7, 2019
…ent to a new array Signed-off-by: DL6ER <dl6er@dl6er.de>
AzureMarker
reviewed
May 10, 2019
Signed-off-by: DL6ER <dl6er@dl6er.de>
AzureMarker
approved these changes
May 11, 2019
AzureMarker
added a commit
that referenced
this pull request
Sep 11, 2019
…g_by_id Fix sorting of queries with identical timestamps
|
This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there: https://discourse.pi-hole.net/t/pi-hole-4-3-2-release-notes/23852/1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm the following:
git rebase)git commit --signoff)What does this PR aim to accomplish?:
Queries with identical timestamps are sorted in the wrong order when looking at the query log data descending. See #934 for further details. This PR fixes #934.
How does this PR accomplish the above?:
Modify timestamps during loading to make them non-unique. Our modification is reverted when we convert the UNIX timestamp to a formatted date string. This allows us to fix this issue with
What documentation changes (if any) are needed to support this PR?:
None, this PR does not break anything.