Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coloured rectangles in legend of 'Queries answered by' link to empty query list #1705

Closed
3 tasks done
churchofnoise opened this issue May 21, 2020 · 7 comments · Fixed by #1707 or #1708
Closed
3 tasks done

Comments

@churchofnoise
Copy link

In raising this issue, I confirm the following: {please fill the checkboxes, e.g: [X]}

How familiar are you with the the source code relevant to this issue?:

1


Expected behaviour:

When clicking on one of the 'sources' for answered queries graph legend (blocklist, cache, ...), I expect to get a list of recent queries answered by that element (e.g. in my case, if I click on 'localhost' I expect to see the queries answered by Unbound)

Actual behaviour:

When clicking on the coloured rectangle of one of the answering elements (blocklist, cache, ...), I get an empty list ('No data available in table') as this directs to http:///admin/queries.php?forwarddest=

When clicking on the text of one of the answering elements (blocklist, cache, ...), I get the recent queries that are answered by that element as this directs to http:///admin/queries.php?forwarddest=
Steps to reproduce:

Click on rectangle next to name of answering element -> empty list ==BUG
Click on name of answering element = list of recent queries answered by that element == OK

Debug token provided by uploading pihole -d log:

https://tricorder.pi-hole.net/4ycder3y90

@yubiuser
Copy link
Member

I can confirm this behavior.

@churchofnoise
Copy link
Author

Should this issue rather be in the AdminLTE section perhaps?

@DL6ER
Copy link
Member

DL6ER commented Jan 17, 2021

@churchofnoise Yes, sorry, that's likely the reason for why it hasn't be seen (at least not by me). I'll move it now (but to FTL where we'll fix it). It should get fixed when we fix pi-hole/FTL#1026

@DL6ER DL6ER transferred this issue from pi-hole/pi-hole Jan 17, 2021
@DL6ER
Copy link
Member

DL6ER commented Jan 18, 2021

@churchofnoise @yubiuser

Could you test whether running

pihole checkout ftl fix/querylog_filtering

fixes the described issue for you?

@churchofnoise
Copy link
Author

It doesn't, I think this one comes down to a link in AdminLTE...

@DL6ER
Copy link
Member

DL6ER commented Jan 18, 2021

Yes, rereading your issue this is clear. Sorry for the confusion. One should probably do fewer things at once...

@DL6ER DL6ER transferred this issue from pi-hole/FTL Jan 18, 2021
@churchofnoise
Copy link
Author

No worries, this one is not that critical :)
Keep up the good work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants