Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent S6 timeouts on container start by setting S6_CMD_WAIT_FOR_SERVICES_MAXTIME to 0 #1192

Merged
merged 2 commits into from Aug 29, 2022
Merged

Prevent S6 timeouts on container start by setting S6_CMD_WAIT_FOR_SERVICES_MAXTIME to 0 #1192

merged 2 commits into from Aug 29, 2022

Conversation

PromoFaux
Copy link
Member

What does this PR aim to accomplish?:

per just-containers/s6-overlay#452

Should fix #1186 (and other similar reports)

Confirmed working here: #1186 (comment)

By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  • I have read the above and my PR is ready for review. Check this box to confirm

@PromoFaux
Prevent S6 timeouts on container start by setting S6_CMD_WAIT_FOR_SER…
27980ed 
…VICES_MAXTIME to 0, per just-containers/s6-overlay#452

Signed-off-by: Adam Warner <me@adamwarner.co.uk>
@PromoFaux
Read CAP_STR into an array and output one cap per line in startup
efd587b 
Signed-off-by: Adam Warner <me@adamwarner.co.uk>
@sonarcloud
Copy link

sonarcloud bot commented Aug 29, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@PromoFaux PromoFaux merged commit a4c931f into dev Aug 29, 2022
@PromoFaux PromoFaux deleted the s6-wait-maxtime branch August 29, 2022 15:52
@corasaniti corasaniti mentioned this pull request Aug 30, 2022
Closed
@juliusvonkohout juliusvonkohout mentioned this pull request Dec 7, 2023
Closed
juliusvonkohout added a commit to juliusvonkohout/kubeflow that referenced this pull request Dec 7, 2023
@juliusvonkohout
Prevent S6 timeouts on container start by setting S6_CMD_WAIT_FOR_SER…
da1b9fc 
…VICES_MAXTIME to 0

Might be needed for slow storage see pi-hole/docker-pi-hole#1192
@juliusvonkohout juliusvonkohout mentioned this pull request Dec 7, 2023
Merged
google-oss-prow bot pushed a commit to kubeflow/kubeflow that referenced this pull request Jan 27, 2024
@juliusvonkohout
Prevent S6 timeouts on container start by setting S6_CMD_WAIT_FOR_SER… (
1efae04 
#7421)

Might be needed for slow storage see pi-hole/docker-pi-hole#1192
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@PromoFaux