Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Master Blacklist combined as one ASCII database based on different text files #1505

Closed
3 tasks done
ghost opened this issue May 31, 2017 · 4 comments
Closed
3 tasks done

Comments

@ghost
Copy link

ghost commented May 31, 2017

In raising this issue, I confirm the following (please check boxes, eg [X]) Failure to fill the template will close your issue:

How familiar are you with the codebase?:
1


[FEATURE REQUEST]:

It is excellent to have a possibility to configure seperate blacklists.

Having done that, the question is to use it.

I suggest a feature to mapping and combining such blacklists

  1. to a single interface of the server
  2. to a single host making the DNS queries
  3. to multiple hosts making the DNS queries

The combined list may not be available for user handling from the web interface. This may be only for internal functioning for performance reasons.

With this system, certain blacklist would be combined to one ASCII file put together for DNS queries.

Currently, pi-Hole uses ASCII text file database to store and search information. It searches line by line and compares all domains in it. If there are many such files, it will go sequentially one by one to find a domain name in these ASCII text files.

Lets say the domain in question is configured in file_5.text. Here, it will go through all the four files, file_1.txt, file_2.txt, file_3.txt, file_4.txt before landing in the file file_5.txt.

With this, it connects to the haddrive five times and loads it into memory.

With my suggestion, if - as in the above example - all files are combined into one, then the SEARCHES PER QUERY would be much faster. By installing such a system, one could enhance it to detect queries coming from a particular host and combine text files based on those mappings.

This template was created based on the work of udemy-dl.

@technicalpyro
Copy link
Contributor

please also make this a feature request that could be voted on using the discourse forums http://discourse.pi-hole.net

@ghost
Copy link
Author

ghost commented May 31, 2017

Thanks technicalpyro 💯

Can I have your vote and comment here please:
https://discourse.pi-hole.net/t/master-blacklist-combined-as-one-ascii-database-based-on-different-text-files/3462

@dschaper
Copy link
Member

Topic opened on Discourse, closing this one.

@pralor-bot
Copy link

This issue has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/master-blacklist-combined-as-one-ascii-database-based-on-different-text-files/3462/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants