Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uninstalling Pi-hole removes (?) rsync #1605

Closed
3 tasks done
beatschubser opened this issue Jul 14, 2017 · 4 comments
Closed
3 tasks done

Uninstalling Pi-hole removes (?) rsync #1605

beatschubser opened this issue Jul 14, 2017 · 4 comments

Comments

@beatschubser
Copy link

  • I have read and understood the contributors guide.
  • The issue I am reporting can be replicated
  • The issue I am reporting isn't a duplicate (see FAQs,

How familiar are you with the codebase?: 1


[BUG REPORT]:

[BUG | ISSUE] Actual Behaviour:

After uninstalling Pi-hole and most of its dependencies (except for curl, wget and unzip) the rsync-command cannot be executed any more -> "Command not found".

I have tested this three times, so I guess it is reproducible.

[BUG | ISSUE] Steps to reproduce:

Uninstall Pi-hole with "sudo pihole uninstall". Remove all dependencies except for curl, wget and unzip. I don't know if this also happens when you don't remove any dependencies.

@dschaper
Copy link
Member

The dependencies include utilities that are already installed on various distributions, they should not all be removed, or you will take out packages that existed prior to installing the Pi-hole. Uninstalling the Pi-hole software via the script isn't the best currently, but just walking through the script and uninstalling everything without checking to see what utilities and software will be removed when done manually will break your OS.

@beatschubser
Copy link
Author

beatschubser commented Jul 14, 2017

Fair enough, but then the script shouldn't say

SAFE TO REMOVE ALL ON RASPBIAN

What's the best way to uninstall Pi-hole? Love the tool, but it crashes my SmartHome-Server (FHEM).

@jacobsalmela
Copy link
Contributor

This does not seem to be an issue on v3.2--we did give the uninstaller some love, but it appears to be fixed.

root@debian:~# which rsync
/usr/bin/rsync
root@debian:~# pihole uninstall
  [?] Are you sure you would like to remove Pi-hole? [y/N] y
  [✓] Root user check
  [i] Be sure to confirm if any dependencies should not be removed
  [i] The following dependencies may have been added by the Pi-hole install:
    apt-utils dialog debconf dhcpcd5 git iproute2 whiptail bc cron curl dnsmasq dnsutils iputils-ping lsof netcat sudo unzip wget idn2 lighttpd php5-common php5-cgi php5-sqlite 
  [?] Do you wish to go through each dependency for removal? (Choosing No will leave all dependencies installed) [Y/n] y

  [?] Do you wish to remove apt-utils from your system? [Y/N] y
  [i] Removed apt-utils
  [?] Do you wish to remove dialog from your system? [Y/N] y
  [i] Removed dialog
  [?] Do you wish to remove debconf from your system? [Y/N] y
  [i] Removing debconf...root@debian:~# which rsync
/usr/bin/rsync

Tried on CentOS as well:

[root@centos ~]# which rsync
/usr/bin/rsync
[root@centos ~]# pihole uninstall
  [?] Are you sure you would like to remove Pi-hole? [y/N] y
  [✓] Root user check
  [i] Be sure to confirm if any dependencies should not be removed
  [i] The following dependencies may have been added by the Pi-hole install:
    dialog git iproute net-tools newt procps-ng epel-release bc bind-utils cronie curl dnsmasq findutils nmap-ncat sudo unzip wget libidn2 psmisc lighttpd lighttpd-fastcgi php php-common php-cli php-pdo 
  [?] Do you wish to go through each dependency for removal? (Choosing No will leave all dependencies installed) [Y/n] y

  [?] Do you wish to remove dialog from your system? [Y/N] y
  [i] Removed dialog
  [?] Do you wish to remove git from your system? [Y/N] y
  [i] Removed git
  [?] Do you wish to remove iproute from your system? [Y/N] y
  [i] Removed iproute
  [?] Do you wish to remove net-tools from your system? [Y/N] y
  [i] Removed net-tools
  [?] Do you wish to remove newt from your system? [Y/N] y
  [i] Removed newt
  [?] Do you wish to remove procps-ng from your system? [Y/N] y
  [i] Removing procps-ng...
[root@centos ~]# which rsync
/usr/bin/rsync

@pralor-bot
Copy link

This issue has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/no-wi-fi-or-raspi-config-after-uninstall/39987/8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants