Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong text/suggestion in Advanced DNS settings #893

Closed
3 tasks done
HellStorm666 opened this issue Aug 22, 2018 · 3 comments
Closed
3 tasks done

Wrong text/suggestion in Advanced DNS settings #893

HellStorm666 opened this issue Aug 22, 2018 · 3 comments
Assignees

Comments

@HellStorm666
Copy link

In raising this issue, I confirm the following: {please fill the checkboxes, e.g: [X]}

How familiar are you with the the source code relevant to this issue?:

{1}


Expected behaviour:

{Pi-hole should use conditional forwarding from the DHCP server.}

Actual behaviour:

{There is asked to fill in the address of the router, what isn't the same}

Troubleshooting undertaken, and/or other relevant information:

{Steps of what you have done to fix this}

The text under Advanced DNS settings, Conditional Forwarding should ask to fill in the address and local domain of the DHCP server.
This could be the Router, but in a lot of cases this isn't the router.

The text now is:

Conditional Forwarding
If not configured as your DHCP server, Pi-hole won't able to determine the names of devices on your local network. As a result, tables such as Top Clients will only show IP addresses.

One solution for this is to configure Pi-hole to forward these requests to your home router, but only for devices on your home network. To configure this we will need to know the IP address of your router and the name of your local network.

Note: The local domain name must match the domain name specified in your router, likely found within the DHCP settings.

And should be:

Conditional Forwarding
If not configured as your DHCP server, Pi-hole won't able to determine the names of devices on your local network. As a result, tables such as Top Clients will only show IP addresses.

One solution for this is to configure Pi-hole to forward these requests to your DHCP server (most likely your router), but only for devices on your home network. To configure this we will need to know the IP address of your DHCP server and the name of your local network.

Note: The local domain name must match the domain name specified in your DHCP server, likely found within the DHCP settings.
@AzureMarker
Copy link
Contributor

Open a PR for this change, it looks good. The "likely found within the DHCP settings" part could also get removed since it's already talking about the DHCP server settings.

@dschaper dschaper self-assigned this Jan 15, 2019
@dschaper
Copy link
Member

Text is in settings.php in the AdminLTE portion of the project. Moving this over to that repo and will PR.

@dschaper dschaper transferred this issue from pi-hole/pi-hole Jan 15, 2019
@DL6ER
Copy link
Member

DL6ER commented Jan 16, 2019

This could be the Router, but in a lot of cases this isn't the router.

I disagree. The vast majority of users install it in their home networks which have the most simple topology you can imagine (devices connected to a router). Nevertheless, your suggested change is good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants