Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/api.php?recentBlocked Not Working #3980

Closed
C4Wiz opened this issue Jan 11, 2021 · 5 comments
Closed

/api.php?recentBlocked Not Working #3980

C4Wiz opened this issue Jan 11, 2021 · 5 comments
Labels
Issue: Won't Fix Intended behavior, will not be fixed

Comments

@C4Wiz
Copy link

C4Wiz commented Jan 11, 2021

Versions

  • Pi-hole: 5.2.2
  • AdminLTE: 5.2.2
  • FTL: 5.3.4

Platform

  • OS and version: Debian Buster
  • Platform: Raspberry Pi

Expected behavior

/api.php?recentBlocked should return last blocked domain
A clear and concise description of what you expected to happen.

Actual behavior / bug

/api.php?recentBlocked returns []
A clear and concise description of what the bug is.

Steps to reproduce

http://ip/admin/api.php?recentBlocked
Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Debug Token

  • URL:

Screenshots

If applicable, add screenshots to help explain your problem.

Additional context

Add any other context about the problem here.

@C4Wiz
Copy link
Author

C4Wiz commented Jan 16, 2021

has anyone looked into this yet?

@dschaper
Copy link
Member

pi-hole/web#1650

@dschaper
Copy link
Member

This is intended behavior. You'll need to be logged in or pass the auth token to access that information now.

@dschaper dschaper added the Issue: Won't Fix Intended behavior, will not be fixed label Jan 16, 2021
@C4Wiz
Copy link
Author

C4Wiz commented Jan 16, 2021

thank you, thats my bad for not reading the pull requests.

@DL6ER
Copy link
Member

DL6ER commented Jan 16, 2021

It shouldn't have been exposed without password before so this was fixing incorrect behavior now. Assuming someone continuously scanning the API endpoint. They could reconstruct your entire list of blocked domains.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue: Won't Fix Intended behavior, will not be fixed
Projects
None yet
Development

No branches or pull requests

3 participants