Restore does not include static dhcp leases without ip

[wexman]

Versions

• Pi-hole: v5.17.3
• AdminLTE: v5.21
• FTL: v5.24

Platform

• OS and version: Debian 12

• Platform: Proxmox LXC

Expected behavior

When restoring data from a backup, I expect static dhcp leases to be included even if they have no ip address assigned (but the name only).

Actual behavior / bug

When restoring data from a backup, static dhcp leases without ip address are skipped (=not restored).

Steps to reproduce

Steps to reproduce the behavior:

1. Have static dhcp leases with only mac address and name
2. Backup data from settings => teleporter
3. Restore this backup to a fresh instance of pihole
4. See no static leases without ip address

Additional context

The missing entries are included in the backup, I can see them in the archive file unter dnsmasq.d -> pihole-static-dhcp.conf, so it seems to be the restore code that is not working as expected.

I do have quite a lot of these entries where I don't care about the actual address, but want to assign a certain name.

[wexman]

By the way, wouldn't it be better if these were called "permanent leases" instead of "static leases" to avoid confusion with static ip addresses which are significantly different?

[yubiuser]

Thanks for your report. I did not track the issue down but tried it with the upcoming Pi-hole v6 (which uses a completely different approach for the backup) and it worked without issues.
Whatever the issue in v5 is - it's fixed in v6

[wexman]

Thanks, then I'll happily wait for the new version!