Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Domains from saved lists still get applied even when removed from the sources array #86

Closed
jacobsalmela opened this issue Nov 23, 2015 · 3 comments
Labels
Bug: Confirmed Verified as a bug to be resolved

Comments

@jacobsalmela
Copy link
Contributor

This only happens in a few circumstances, but as an example, say you used the mahakala list at one point and then decided you did not want it anymore so you either comment it out or remove it from the sources array and then run gravity.sh to apply the changes.

This doesn't work because the list.n.adblock.mahakala.is.domains file already exists in /etc/pihole/ from when the script ran previously. So when the find command searches for any .domains file to use to create the aggregated list, it will still apply the mahakala list because that file is still there.

So some sort of logic needs to exist that verifies that the domains in the sources array match the files that exist in /etc/pihole/ so only the correct ones apply.

Another instance when this happened is when a user added multiple new sources and then decided not to use them, but since the files were still there, they were applied anyway.

@jacobsalmela jacobsalmela added the Bug: Confirmed Verified as a bug to be resolved label Nov 23, 2015
@dschaper
Copy link
Member

Fixed, confirmed by commenting out domains and noting the decrease in number of blocked domains reported. Domains restored when uncommented.

@jacobsalmela
Copy link
Contributor Author

Wow! Nice, thanks. It's getting hard to keep up with you! But that's a good thing. I'll have some time over thanksgiving to test everything and try to merge it all without any conflicts.

@dschaper
Copy link
Member

Sounds good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug: Confirmed Verified as a bug to be resolved
Projects
None yet
Development

No branches or pull requests

2 participants