You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This only happens in a few circumstances, but as an example, say you used the mahakala list at one point and then decided you did not want it anymore so you either comment it out or remove it from the sources array and then run gravity.sh to apply the changes.
This doesn't work because the list.n.adblock.mahakala.is.domains file already exists in /etc/pihole/ from when the script ran previously. So when the find command searches for any .domains file to use to create the aggregated list, it will still apply the mahakala list because that file is still there.
So some sort of logic needs to exist that verifies that the domains in the sources array match the files that exist in /etc/pihole/ so only the correct ones apply.
Another instance when this happened is when a user added multiple new sources and then decided not to use them, but since the files were still there, they were applied anyway.
The text was updated successfully, but these errors were encountered:
Wow! Nice, thanks. It's getting hard to keep up with you! But that's a good thing. I'll have some time over thanksgiving to test everything and try to merge it all without any conflicts.
This only happens in a few circumstances, but as an example, say you used the mahakala list at one point and then decided you did not want it anymore so you either comment it out or remove it from the
sources
array and then rungravity.sh
to apply the changes.This doesn't work because the
list.n.adblock.mahakala.is.domains
file already exists in/etc/pihole/
from when the script ran previously. So when thefind
command searches for any.domains
file to use to create the aggregated list, it will still apply the mahakala list because that file is still there.So some sort of logic needs to exist that verifies that the domains in the
sources
array match the files that exist in/etc/pihole/
so only the correct ones apply.Another instance when this happened is when a user added multiple new sources and then decided not to use them, but since the files were still there, they were applied anyway.
The text was updated successfully, but these errors were encountered: