Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Gravity page is redirect depending on the settings level #2992

Closed
rdwebdesign opened this issue Mar 23, 2024 · 1 comment · Fixed by #2993
Closed

Update Gravity page is redirect depending on the settings level #2992

rdwebdesign opened this issue Mar 23, 2024 · 1 comment · Fixed by #2993

Comments

@rdwebdesign
Copy link
Member

Versions

Current development-v6 branch

Bug description

After #2882 the Tools > Update Gravity page is automatically redirected to Settings page.

This is happening because the function applyExpertSettings() is triggering a redirect if there are no visible .box elements on the page.

The real issue is:
this should be triggered only inside Settings pages, not in Tools (or any other page).

Steps to reproduce

Steps to reproduce the behavior:

  1. Go to any Settings page and select BASIC level.
  2. Go to Tools > Update Gravity
  3. The page will be automatically redirected (but it shouldn't be).

Additional context

Reported on Discourse:
https://discourse.pi-hole.net/t/update-gravity-website-broken-reproducable-and-possible-solution-found

@DL6ER DL6ER mentioned this issue Mar 23, 2024
5 tasks
@DL6ER DL6ER linked a pull request Mar 23, 2024 that will close this issue
5 tasks
@rdwebdesign
Copy link
Member Author

Fixed by #2993

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant