You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Noticing that the response from PATH seems to be a text-type instead of json-type response. I'm noticing in the code that the PATH response uses JSONResponse instead of the CustomJSONResponse used by many other endpoints.
As far as I can see, functions either use json response with a dict input:
JSONResponse uses json.dumps to convert the Python dict into a JSON string, and it doesn't handle some types. Pydantic's JSON conversion covers way more types, so I tend to use this instead with CustomJSONResponse.
Noticing that the response from PATH seems to be a text-type instead of json-type response. I'm noticing in the code that the PATH response uses
JSONResponse
instead of theCustomJSONResponse
used by many other endpoints.As far as I can see, functions either use json response with a dict input:
or
CustomJSONResponse
with a string input:the PATCH response is the only one using
JSONResponse
with a string param.I'm guessing this is just a bug (and not a critical one at that) but before I submit a PR to fix I just wanted to make sure.
The text was updated successfully, but these errors were encountered: