Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add signup endpoint #139

Closed
dantownsend opened this issue Apr 19, 2022 · 4 comments
Closed

Add signup endpoint #139

dantownsend opened this issue Apr 19, 2022 · 4 comments
Labels
enhancement New feature or request

Comments

@dantownsend
Copy link
Member

dantownsend commented Apr 19, 2022

We have session_login and session_logout endpoints, which helps with quickly prototyping an app.

It would be great to have a session_signup endpoint too.

It would look very similar to the login form, except with username / email / password / confirm password fields:

Screenshot 2022-04-19 at 19 11 03

@dantownsend dantownsend added the enhancement New feature or request label Apr 19, 2022
@dantownsend dantownsend added this to To do in Enhancements via automation Apr 19, 2022
@sinisaos
Copy link
Member

@dantownsend I was thinking the same thing yesterday and it would be useful. Can I try implement this? My only question is how deep should we go with email and password validation without an external library. Is the html email field enough and is the 6-character password long enough? Or should we go deeper with regular expression?

@dantownsend
Copy link
Member Author

@sinisaos Thanks, it would great if you could take a look. Just a simple regex should be OK for email validation. Even if the first version is very simple, it's still useful. I think we can add hooks at some point, so users can add additional logic for password and email validation.

@sinisaos
Copy link
Member

@dantownsend I will make PR during the day that you can see code changes. We will drop a little bit in coverage because multiple lines like this one used to render errors in the HTML template. I think it's not a big deal.

@dantownsend
Copy link
Member Author

Implemented in #141

Enhancements automation moved this from To do to Done Jun 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

No branches or pull requests

2 participants