Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small bug #163

Closed
sinisaos opened this issue Jul 22, 2022 · 1 comment
Closed

Small bug #163

sinisaos opened this issue Jul 22, 2022 · 1 comment

Comments

@sinisaos
Copy link
Member

I find a small bug. After the last changes in Piccolo ORM Table.__init__ ignore_missing argument is now _ignore_missing and we have to change this line to row = self.table(_ignore_missing=True) otherwise we get 500 Internal Server Error from get_new method. If you want I can change it.
@dantownsend
Copy link
Member

Yes - if you could create a PR that would be great, thanks!

I didn't realise we were using ignore_missing in Piccolo API. I try and avoid breaking changes, it's my mistake.

@sinisaos sinisaos mentioned this issue Jul 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dantownsend @sinisaos