braids decimation with envelope & AD_VCA

[boochow]

Hello! I am currently porting braids onto KORG drumlogue and have a question about this code

eurorack/braids/braids.cc

Lines 285 to 288 in d1d8839

	if ((i % decimation_factor) == 0) {
	sample = render_buffer[i] & bit_mask;
	}
	sample = sample * gain_lp >> 16;

When decimation_factor = n, the code multiplies gain_lp to sample n times, so the value of sample goes to sample * pow(gain_lp, n), then when (i % decimation_factor) == 0 becomes true, the new value is loaded from render_buffer.
Is this the intended behavior?
I mean, why the code wasn't like this?

    if ((i % decimation_factor) == 0) {
      sample = render_buffer[i] & bit_mask;
    }
    int16_t decimated_sample = sample * gain_lp >> 16;

[pichenettes]

You're right, this is a stupid bug and you can fix it.