Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace 'null input buffer' message from Cipher.doFinal() with more i… #35

Merged
merged 1 commit into from Nov 29, 2017
Merged

Replace 'null input buffer' message from Cipher.doFinal() with more i… #35

merged 1 commit into from Nov 29, 2017

Conversation

csutherl
Copy link
Contributor

…nformative message by catching empty vault data before passing to Cipher, logging it, and throwing an exception.

With this commit we see the following:

SEVERE: Data not found in alias (my_vault) for VAULT::my_block::manager_password1::
org.apache.tomcat.vault.security.vault.SecurityVaultException: Data not found in alias (my_vault) for VAULT::my_block::manager_password1::
	at org.apache.tomcat.vault.security.vault.PicketBoxSecurityVault.retrieve(PicketBoxSecurityVault.java:272)
....

instead of:

SEVERE [main] org.apache.tomcat.vault.util.PropertySourceVault.getProperty java.lang.IllegalArgumentException: Null input buffer
--
org.apache.tomcat.vault.security.vault.SecurityVaultException: java.lang.IllegalArgumentException: Null input buffer
at org.apache.tomcat.vault.security.vault.PicketBoxSecurityVault.retrieve(PicketBoxSecurityVault.java:299)
....

…nformative message by catching empty vault data before passing to Cipher, logging it, and throwing an exception
@jfclere jfclere merged commit c2c9dd0 into web-servers:master Nov 29, 2017
@csutherl csutherl deleted the update-null-input-buffer-exception branch November 29, 2017 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants