Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breadcrumbs are aligned too far to the left #237

Closed
pauloxnet opened this issue Sep 12, 2022 · 3 comments · Fixed by #239
Closed

Breadcrumbs are aligned too far to the left #237

pauloxnet opened this issue Sep 12, 2022 · 3 comments · Fixed by #239

Comments

@pauloxnet
Copy link
Contributor

Describe the issue

Current Behavior

Breadcrumbs first element is aligned too far to the left.

Expected Behavior

Breadcrumbs first element correctly aligned in the left.

Disclaimer

I'm not a CSS expert but I was using the new breadcrumbs feature from the latest version of Pico.css in my static blog and I noticed this issue at low resolution in the responsive mode in Firefox.

Reproduction URL

I don't know how to produce a minimal test with CodePen.
I would link my website here but this practice has been expressly discouraged in the issue template.

Environment

  • Ubuntu 22.04
  • Firefox 104.0.2 64bit

Solution

I solved this issue in my blog avoiding to apply the padding rule to the breadcrumbs first li element, as below:

  &[aria-label="breadcrumb"] {
    align-items: center;
    justify-content: left;

    & ul li {
+     &:not(:first-child) {
      padding-inline-start: 0;
+     }
      &:not(:last-child) {
        a::after {
          padding-inline-start: 0.5rem;
          content: "/";
          color: var(--muted-color);
        }
      }
    }

    & a[aria-current="page"] {
      color: inherit;
    }
  }

Code link

@pauloxnet pauloxnet changed the title Breadcrumbs is aligned too far to the left Breadcrumbs are aligned too far to the left Sep 12, 2022
@lucaslarroche lucaslarroche mentioned this issue Sep 12, 2022
@lucaslarroche lucaslarroche linked a pull request Sep 12, 2022 that will close this issue
@lucaslarroche
Copy link
Member

lucaslarroche commented Sep 12, 2022

Hi @pauloxnet,
Thank you. Good find.

I improved the breadcrumb. Preview here, PR here.

Feedback is welcome.

@pauloxnet
Copy link
Contributor Author

Hi @lucaslarroche,

I am glad that my issue report was useful. Thanks for improving the breadcrumbs. The preview seems fine to me.

@lucaslarroche
Copy link
Member

Thank you, merged in v.1.5.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants