Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 2 cards have almost no padding #504

Closed
Atmos4 opened this issue Apr 2, 2024 · 3 comments
Closed

Version 2 cards have almost no padding #504

Atmos4 opened this issue Apr 2, 2024 · 3 comments

Comments

@Atmos4
Copy link

Atmos4 commented Apr 2, 2024

Describe the issue

The card padding is a lot smaller than with v1. This changes the look and feel of cards from v1, making the migration not super smooth.

Note: This change may be intended. If it is, I will just override card styles in my projects :)

Reproduction URL

CodePen
Card documentation

Environment

Irrelevant

@carlreinke
Copy link

I, on the other hand, removed my padding-reduction style customization when upgrading to v2. Padding in v1 was excessive.

@Sammy-T
Copy link

Sammy-T commented Jun 20, 2024

Comparing my project with the Pico website, it looks like v2 is missing some media queries for article that are applied on the Pico site. My cards and modals both seem to have smaller padding than what I was expecting.

@Atmos4
Copy link
Author

Atmos4 commented Jun 25, 2024

@Sammy-T I think it is the exact same styling on the documentation than in the code (otherwise it would be pretty weird).

I will assume the change is intended and close this issue. Still a good thing to know that cards are not behaving the exact same!

@Atmos4 Atmos4 closed this as completed Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants