This repository has been archived by the owner on Jan 30, 2024. It is now read-only.
NoRecordsMatchException should be served with HTTP code 200 #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would it be possible to tag this commit? Tnx is advance. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The OAI standard states:
-OAI-PMH errors are distinguished from HTTP Status-Codes
-OAI-PMH repositories may employ HTTP Status-Codes in addition to "200 OK"
This PR makes sure the NoRecordsMatchException error is served with a Status 200 response, as the current 400 status does not reflect the nature of the OAI response.