This repository has been archived by the owner on Jan 30, 2024. It is now read-only.
Fixed feature as agreed with David: Provider's getResponse method cat… #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ches now any \Expression, makes am OaiPmh-Expressions out of it and adds to the xml for erroneous response.
…tance of an Oai-Exception then it is just added as an error Element directly to erroneous xml response. Otherwise it is converted, using its message, into a non-complete OaiException (i.e. without an oai error code). To handle the second case, ResponseDocument->addError is changed so that if there is no error code, then the OBLIGATORY attribute with generic value 'badArgument' is added. Possible better way to handle the situation with a generic exception: to add 'InternalServerError' to the list of admissible error code values in the scheme for OAI errors and replace 'badArgument' in addError with 'InternalServerError'.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ches now any \Expression, makes am OaiPmh-Expressions out of it and adds to the xml for erroneous response.