Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bounding of polyhedral dice in 'op_transform()' #324

Open
trevorld opened this issue Mar 6, 2023 · 1 comment
Open

Bounding of polyhedral dice in 'op_transform()' #324

trevorld opened this issue Mar 6, 2023 · 1 comment
Assignees
@trevorld
Labels
bug Something isn't working

Comments

@trevorld
Copy link
Member

trevorld commented Mar 6, 2023 •
edited

  • op_transform() currently assumes polyhedral dice are bounded by the 3D prism that bounds the top face.
  • Except for the d4 and d6 dice the other polyhedral dice physically expand past this prism.
  • However, unsure what practical situations where the better bound would actually be needed...
@trevorld trevorld added the bug Something isn't working label Mar 6, 2023
@trevorld
Copy link
Member Author

trevorld commented Mar 7, 2023

We probably want an accurate "bounding box" for aabb_piece(). aabb_piece() is used by geom_piece() and render_piece().

@trevorld trevorld self-assigned this Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@trevorld trevorld

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@trevorld