Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Stop Using Global Variables in Copilot.tsx - Refactor GlobalConversationID #115

Open
Arindam200 opened this issue Jun 3, 2024 · 6 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers in the OSP Community.

Comments

@Arindam200
Copy link
Contributor

Description:

In the Copilot.tsx file, we are currently using a global variable GlobalConversationID. To improve code maintainability and avoid potential issues related to global state, we should refactor the code to eliminate the use of this global variable.

Proposed Change:

Refactor the code to use a more localized state management approach, such as React's useState or useContext for managing the conversation ID.

Steps to Reproduce:

  1. Open the Copilot.tsx file.
  2. Locate the usage of the global variable GlobalConversationID.
  3. Refactor the code to use a more localized state management approach.

Expected Outcome:

The code should no longer use the global variable GlobalConversationID, and instead, manage the conversation ID using a more localized state management approach.

Additional Notes:

  • Ensure that the refactored code is tested thoroughly to confirm that it works as expected.
  • Consider the impact on other parts of the application that might be using GlobalConversationID and refactor them accordingly.

Feel free to reach out if there are any questions or further clarifications needed.

@Arindam200 Arindam200 added the enhancement New feature or request label Jun 3, 2024
@shivay-at-pieces shivay-at-pieces added the good first issue Good for newcomers in the OSP Community. label Jun 3, 2024
@Asin-Junior-Honore
Copy link

Hey @Arindam200 and @shivay-at-pieces could this issue be assigned to me please ,I would like to work on this

@shagunsharma6677
Copy link

Hey @Arindam200 & @shivay-at-pieces could you please assign this issue to me if no one is working in it. I have gone though the code base and understand the enhancement need to be done.

Thanks

@Arindam200
Copy link
Contributor Author

Hey @Asin-Junior-Honore, Sorry for the delayed response.

Are you still interested to work on this?

Otherwise, we'll assign this to @shagunsharma6677

@Asin-Junior-Honore
Copy link

@Arindam200 yea sure am still interested to work on the issue , thanks

@shagunsharma6677
Copy link

Let me know if you need any help from my side @Asin-Junior-Honore.

@Asin-Junior-Honore
Copy link

hey 👋
@shagunsharma6677 please kindly review my PR thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers in the OSP Community.
Projects
None yet
Development

No branches or pull requests

4 participants