Lower minimum dependency

[iainconnor]

Right now you are manually including API Level 15, but most of the functionality you're relying on has been present in Android since before that (at least up until API Level 10, where RXJava is supported). Previously, you would receive an error message like this if attempting to use this library on an earlier version;

ERROR: Debug has an indirect dependency on Android API level 15, but minSdkVersion for variant 'Debug' is API level 10

After this change, I was able to build a project and run it on an Android 2.3.7 device properly.

Keep up the great work! This library shows a ton of promise.

[iainconnor]

Some of the other minor changes were just from the code style checker warning me of violations that needed to be fixed before the project would ./gradlew build.

[AndrewReitz]

Thanks! I always planned on having this work on all versions. I will take a look, and get this merged in when I get a chance.

[iainconnor]

Might be nice to integrate this with https://github.com/JakeWharton/sdk-manager-plugin, so that the Android-20 (or whatever version you eventually build against) will be automatically downloaded if its not already present in the builder's Android SDK directory (or, you know, Google could just do the sane thing and actually include the SDKs in MavenCentral 😁 A man can dream, can't he?)

[AndrewReitz]

In order to integrate with that I think the main lib would need to be moved to an aar, which is what I was thinking anyways. I'll be super busy and possibly with out internet for a few days, so as soon as I get a chance I'll check that out and get this PR merged in.

And yes, every day I hope Google will start putting android libraries into central. Maybe one day...

[AndrewReitz]

I finally found a 2.3 device to test on. All the samples and tests actually run on it. This is a bug I introduced where the variables in the ext closure are never actually used. I just fixed that.

Can you provide more information on how you are getting ERROR: Debug has an indirect dependency on Android API level 15. How are you including the library in your project?

[AndrewReitz]

Just pushed the latest changes to artifactory. Can you see if they help.

repositories {
  jcenter()
  maven {
    url = 'https://oss.jfrog.org/oss-snapshot-local/'
  }
}

...

 dependencies {
  compile 'com.andrewreitz:shillelagh:0.4.0-SNAPSHOT'
  provided 'com.andrewreitz:shillelagh-processor:0.4.0-SNAPSHOT'
  ...
}

[iainconnor]

Yup, you're right, works fine for me. Maybe I was doing something strange with building or including the library on my end. Thanks for looking into this! Will close this PR now.

[AndrewReitz]

The snapshot ended up solving it?

[AndrewReitz]

Also, sorry, I did a rebase which screwed up giving you credit for the checkstyle fixes.

[iainconnor]

Yup, snapshot is working fine. No problem about the checkstyles :) Thanks again!

[AndrewReitz]

Great! I was having issues with the samples running in the snapshot now :) I need to figure out a balance between the two...