implement argument passing #56
Conversation
implement argument passing fix a collision between alias and subcommands remove unused structures
|
Awesome! Thanks for the contribution @jayong93 :) I know @Plommonsorbet created this issue thread #37 a while ago where we were discussing this. I'm sure he'll be able to give a good review. It's about time we implemented this feature, so I'm glad you got the ball rolling. I'll take a look at the PR this weekend too and see what the issue is. |
|
Hey, thanks for getting started on this feature, like @BenSchZA mentions I think there is a discussion to be had for how we actually want this to look like. That conversation is best had in the related issue though. However when we have the implementation details I'd be happy to walk you through implementing the feature and adding the appropriate tests so that this feature can be totally your contribution. :) Some points that came to mind in general that we should pro
|
|
Implemented in #62 . |
If pier supports passing arguments to the scripts, it would be flexible. So I have tried to implement.
I wanted to split alias and arguments which are combined into a
Vec<String>inClistructure, but when I tried, the binary always crashed. I would happy if someone implements that :).