Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please republish with MIT license #147

Closed
morfey13 opened this issue Oct 19, 2020 · 18 comments · Fixed by testing-library/dom-testing-library#1219
Closed

Please republish with MIT license #147

morfey13 opened this issue Oct 19, 2020 · 18 comments · Fixed by testing-library/dom-testing-library#1219

Comments

@morfey13
Copy link

Could you please republish lib to npm with MIT license: we can't use lib with WTFPL license

@Rycochet
Copy link
Collaborator

For now install from the github repo directly - the version is identical, so we can't just publish the same version again.

npm install https://github.com/pieroxy/lz-string.git

I'm hoping to get some time to convert this over to Typescript soon which will necessitate a bump (but otherwise should be identical).

@Throttle
Copy link

@Rycochet, in this case could you please publish 1.4.5 with MIT license?

@Rycochet
Copy link
Collaborator

@Throttle I've not personally got access for that - in legal terms the license is stated in the repo and npmjs is not a source of truth for that - if your automated tools need the correct license then use the github install as stated above

@revelt
Copy link

revelt commented Jan 24, 2023

CC @pieroxy do you still have the npm publishing rights?

@pieroxy
Copy link
Owner

pieroxy commented Jan 27, 2023

I should, yes. I'll see what I can do.

Repository owner deleted a comment from Conciergerie-Iskills Jan 27, 2023
@pieroxy
Copy link
Owner

pieroxy commented Jan 27, 2023

Could you please republish lib to npm with MIT license: we can't use lib with WTFPL license

That said, I'd be interested to understand why you cannot use the code with the WTFPL. The WTFPL is literally the most permissive license of them all, since you can do what you want. So just take it and relicense it as MIT if you want.

@Rycochet
Copy link
Collaborator

That said, I'd be interested to understand why you cannot use the code with the WTFPL. The WTFPL is literally the most permissive license of them all, since you can do what you want. So just take it and relicense it as MIT if you want.

There's actually a really good reason - the WTFPL is not OSI / open-source compatible according to lawyers - https://opensource.org/licenses/alphabetical - which means that many companies (such as mine) need to specifically discuss what to do (there are libraries out there that can say "yep, this package is OSI compatible so we're good to use it")

@revelt
Copy link

revelt commented Jan 27, 2023

@pieroxy lz-string is a great package, it is still going strong after those years (which proves your skill). It would be unethical for us users to grab it and relicence. Maybe it would make sense to arrange a co-maintainer, somebody who would help with daily maintenance, releases etc? Many popular packages are maintained by multiple people.

@pieroxy
Copy link
Owner

pieroxy commented Jan 27, 2023

I'll publish the lib with the MIT license this weekend. Thanks for the link to the OSI.

@eps1lon
Copy link

eps1lon commented Feb 16, 2023

I'll publish the lib with the MIT license this weekend. Thanks for the link to the OSI.

@pieroxy The release on NPM is still marked as licensed unter WTFPL. Did you publish it somewhere else?

@pieroxy
Copy link
Owner

pieroxy commented Feb 21, 2023

It looks like I am locked out of npmjs. Cannot log in, cannot change my password (looks like something unexpected occurred! when trying) so as of right now, I am trying to get access back to npmjs. I'll let you know when things move forward.

@pieroxy
Copy link
Owner

pieroxy commented Mar 1, 2023

Allright, I am back in. Anyone has any idea how to change the license in npmjs? Should I just release a new version with the only change being the license ?

@Rycochet
Copy link
Collaborator

Rycochet commented Mar 1, 2023

Pretty much - personally I'd do it as a minor release for easy updating for people :-)

@pieroxy
Copy link
Owner

pieroxy commented Mar 1, 2023

How does that work? (I haven't been in npm in about 8 years...)

I just bump the version in package.json and npm publish ?

@Rycochet
Copy link
Collaborator

Rycochet commented Mar 1, 2023

npm version minor then npm publish (and push to git) - been a while since I've done this manually too :-D

@pieroxy
Copy link
Owner

pieroxy commented Mar 1, 2023

Thanks a bunch, will do that.

@pieroxy
Copy link
Owner

pieroxy commented Mar 1, 2023

Allright, I am ready to push it. I'll do that this weekend because if I do something stupid (happened before) I will really not be able to react much in the next couple of days. Expect that early saturday UTC.

@pieroxy
Copy link
Owner

pieroxy commented Mar 4, 2023

There we go. v1.5.0 is live with MIT license. Thanks for the help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants